codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

feat: Update owner query with `isOktaAuthenticated` field #670

Closed RulaKhaled closed 1 month ago

RulaKhaled commented 1 month ago

Purpose/Motivation

What is the feature? Why is this being done? We need this as a flag to tell if current user is OKTA authenticated to display okta banners

Links to relevant tickets

https://github.com/codecov/engineering-team/issues/2053

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (2562256) to head (720d324). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         633      632    -1     
  Lines       17010    17014    +4     
=======================================
+ Hits        15599    15603    +4     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.70% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.70% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/okta_cloud.py 100.00% <100.00%> (ø)
graphql_api/tests/helper.py 100.00% <100.00%> (ø)
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (2562256) to head (720d324). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   91.70%   91.70%           
=======================================
  Files         633      632    -1     
  Lines       17010    17014    +4     
=======================================
+ Hits        15599    15603    +4     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.70% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.70% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/views/okta_cloud.py 100.00% <100.00%> (ø)
graphql_api/tests/helper.py 100.00% <100.00%> (ø)
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.01%. Comparing base (2562256) to head (720d324). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #670 +/- ## =========================================== Coverage 96.01000 96.01000 =========================================== Files 813 814 +1 Lines 18347 18365 +18 =========================================== + Hits 17615 17633 +18 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.70% <100.00%> (+<0.01%)` | :arrow_up: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.70% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.