codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

remove unused code #676

Closed nora-codecov closed 1 month ago

nora-codecov commented 1 month ago

Purpose/Motivation

Found some old code that's no longer in use while I was looking into webhooks and how we set them up. I checked with application team and it seems like they aren't using the _reset_webhook endpoint. All of the functionality to set up webhooks now lives on worker. And it looks like we don't have a delete_webhook anymore.

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (769ed11) to head (f8ddeac).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         628      627    -1     
  Lines       16671    16641   -30     
=======================================
- Hits        15266    15240   -26     
+ Misses       1405     1401    -4     
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.58% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/repo/views.py 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-notifications[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (769ed11) to head (f8ddeac).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   91.57%   91.58%           
=======================================
  Files         628      627    -1     
  Lines       16671    16641   -30     
=======================================
- Hits        15266    15240   -26     
+ Misses       1405     1401    -4     
Flag Coverage Δ
unit 91.58% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.58% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/internal/repo/views.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.93%. Comparing base (769ed11) to head (f8ddeac).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #676 +/- ## ================================================ - Coverage 95.94000 95.93000 -0.01000 ================================================ Files 806 806 Lines 17988 17973 -15 ================================================ - Hits 17258 17243 -15 Misses 730 730 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/676/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/676/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.58% <100.00%> (+<0.01%)` | :arrow_up: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/676/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.58% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.