codecov / codecov-api

Code for the API of Codecov
Other
216 stars 30 forks source link

[fix] Pass extra param in resolver function #686

Closed rohitvinnakota-codecov closed 3 months ago

rohitvinnakota-codecov commented 3 months ago

Purpose/Motivation

What is the feature? Why is this being done?

The determine_entity_redis_key requires both args to be specified even if one of them is None. Updating function call to match the signature.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-notifications[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (24d0bc3) to head (0270d72).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         629      629           
  Lines       16745    16745           
=======================================
  Hits        15344    15344           
  Misses       1401     1401           
Flag Coverage Δ
unit 91.63% <100.00%> (ø)
unit-latest-uploader 91.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (24d0bc3) to head (0270d72).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         629      629           
  Lines       16745    16745           
=======================================
  Hits        15344    15344           
  Misses       1401     1401           
Flag Coverage Δ
unit 91.63% <100.00%> (ø)
unit-latest-uploader 91.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (24d0bc3) to head (0270d72).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #686 +/- ## =========================================== Coverage 95.96000 95.96000 =========================================== Files 808 808 Lines 18077 18077 =========================================== Hits 17347 17347 Misses 730 730 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/686/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <100.00%> (ø)` | | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/686/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.