codecov / codecov-api

Code for the API of Codecov
Other
216 stars 30 forks source link

bundle analysis: when no head commit fall back to report base report #688

Closed JerrySentry closed 3 months ago

JerrySentry commented 3 months ago

closes: https://github.com/codecov/engineering-team/issues/2040

Handles a case where the PR was created without any uploads because all bundles from the build is cached. Instead of showing a "no commit error" we will instead show the parent bundle report as it implies everything was cached and carried over to the head commit.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-notifications[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.60%. Comparing base (50d84e8) to head (772f1ee).

:white_check_mark: All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files         628      628              
  Lines       16714    16717       +3     
==========================================
+ Hits        15312    15314       +2     
- Misses       1402     1403       +1     
Flag Coverage Δ
unit 91.60% <100.00%> (-0.01%) :arrow_down:
unit-latest-uploader 91.60% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/pull/pull.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.60%. Comparing base (50d84e8) to head (772f1ee).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   91.61%   91.60%   -0.01%     
==========================================
  Files         628      628              
  Lines       16714    16717       +3     
==========================================
+ Hits        15312    15314       +2     
- Misses       1402     1403       +1     
Flag Coverage Δ
unit 91.60% <100.00%> (-0.01%) :arrow_down:
unit-latest-uploader 91.60% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
graphql_api/types/pull/pull.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Impacted file tree graph

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.95%. Comparing base (50d84e8) to head (772f1ee).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #688 +/- ## =========================================== Coverage 95.95000 95.95000 =========================================== Files 808 808 Lines 18051 18054 +3 =========================================== + Hits 17321 17324 +3 Misses 730 730 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/688/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/688/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.60% <100.00%> (-0.01%)` | :arrow_down: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/688/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.60% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.