Closed michelletran-codecov closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
:loudspeaker: Thoughts on this report? Let us know!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.63%. Comparing base (
f3d4bdc
) to head (265ee29
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 91.60% 91.63% +0.02%
==========================================
Files 631 632 +1
Lines 16841 16860 +19
==========================================
+ Hits 15428 15449 +21
+ Misses 1413 1411 -2
Flag | Coverage Δ | |
---|---|---|
unit | 91.63% <100.00%> (+0.02%) |
:arrow_up: |
unit-latest-uploader | 91.63% <100.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
codecov_auth/views/okta.py | 100.00% <100.00%> (+1.90%) |
:arrow_up: |
codecov_auth/views/okta_mixin.py | 100.00% <100.00%> (ø) |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.63%. Comparing base (
f3d4bdc
) to head (265ee29
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #691 +/- ##
==========================================
+ Coverage 91.60% 91.63% +0.02%
==========================================
Files 631 632 +1
Lines 16841 16860 +19
==========================================
+ Hits 15428 15449 +21
+ Misses 1413 1411 -2
Flag | Coverage Δ | |
---|---|---|
unit | 91.63% <100.00%> (+0.02%) |
:arrow_up: |
unit-latest-uploader | 91.63% <100.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
codecov_auth/views/okta.py | 100.00% <100.00%> (+1.90%) |
:arrow_up: |
codecov_auth/views/okta_mixin.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.97%. Comparing base (
f3d4bdc
) to head (265ee29
).
:white_check_mark: All tests successful. No failed tests found.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose/Motivation
Refactoring this so that it is more easily shared. Split this from part 2 to make reviewing both parts easier. See Part 2 for more context in how this refactor will be used.
Links to relevant tickets
https://github.com/codecov/engineering-team/issues/1988
What does this PR do?
This moves some of the shared code that will be common in all Okta implementations to a new
mixin
that can be shared across both Views.Notes to Reviewer
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.