codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

bundle analysis: fix module count computation #692

Closed JerrySentry closed 1 month ago

JerrySentry commented 1 month ago

closes https://github.com/codecov/engineering-team/issues/1925

Returns count of number of modules of a bundle report with filtering applied.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-notifications[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (d211946) to head (b21b245).

:white_check_mark: All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   91.63%   91.58%   -0.05%     
==========================================
  Files         628      628              
  Lines       16767    16767              
==========================================
- Hits        15364    15356       -8     
- Misses       1403     1411       +8     
Flag Coverage Δ
unit 91.58% <100.00%> (-0.05%) :arrow_down:
unit-latest-uploader 91.58% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/bundle_analysis.py 97.03% <100.00%> (-2.97%) :arrow_down:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.58%. Comparing base (d211946) to head (b21b245).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   91.63%   91.58%   -0.05%     
==========================================
  Files         628      628              
  Lines       16767    16767              
==========================================
- Hits        15364    15356       -8     
- Misses       1403     1411       +8     
Flag Coverage Δ
unit 91.58% <100.00%> (-0.05%) :arrow_down:
unit-latest-uploader 91.58% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
services/bundle_analysis.py 97.03% <100.00%> (-2.97%) :arrow_down:

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.96%. Comparing base (d211946) to head (b21b245).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #692 +/- ## =========================================== Coverage 95.96000 95.96000 =========================================== Files 808 808 Lines 18104 18104 =========================================== Hits 17374 17374 Misses 730 730 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/692/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.58% <100.00%> (-0.05%)` | :arrow_down: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/692/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.58% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.