codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

Upgrade old packages that relied on distutils #697

Closed michelletran-codecov closed 1 month ago

michelletran-codecov commented 1 month ago

Purpose/Motivation

Builds were failing when setuptools upgraded to 71.x. It looks like they removed their own vendoring of distutils (ref) and that caused any dependencies that we had that referenced distutils to break. So I've upgraded these dependencies to fix the problem.

Depends on: https://github.com/codecov/shared/pull/302

I'm keeping setuptools pinned in the Dockerfile because it feels like the right thing to do (more reliable). Let me know if you're really against that and I will reconsider.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-notifications[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.72%. Comparing base (3eab080) to head (91a4f46).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         632      632           
  Lines       17054    17054           
=======================================
  Hits        15643    15643           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.72% <ø> (ø)
unit-latest-uploader 91.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.72%. Comparing base (3eab080) to head (91a4f46).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         632      632           
  Lines       17054    17054           
=======================================
  Hits        15643    15643           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.72% <ø> (ø)
unit-latest-uploader 91.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.02%. Comparing base (3eab080) to head (91a4f46).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #697 +/- ## =========================================== Coverage 96.02000 96.02000 =========================================== Files 814 814 Lines 18405 18405 =========================================== Hits 17673 17673 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/697/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.72% <ø> (ø)` | | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/697/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.72% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.