codecov / codecov-api

Code for the API of Codecov
Other
216 stars 30 forks source link

109 adjust sentry upload metrics #699

Closed adrian-codecov closed 3 months ago

adrian-codecov commented 3 months ago

I'm adding/adjusting some metrics in the main api upload endpoints to track how often they're called with respect to shelter. Shelter already tracks these as well, https://github.com/codecov/shelter/blob/32f04439fb0d88d0a621f153993f1f264bb29102/upload-ingress/main.py#L41, so you can use Sentry's metrics tab to compare the amount request each gets. This PR is to add a call at the beginning of the call itself and then adjust the current one to represent the "end" of the part we're tracking

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-staging[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.61%. Comparing base (f3d4bdc) to head (2e0ca33).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   91.60%   91.61%           
=======================================
  Files         631      631           
  Lines       16841    16846    +5     
=======================================
+ Hits        15428    15433    +5     
  Misses       1413     1413           
Flag Coverage Δ
unit 91.61% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.61% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/views/commits.py 97.29% <100.00%> (+0.15%) :arrow_up:
upload/views/legacy.py 95.07% <ø> (ø)
upload/views/reports.py 100.00% <100.00%> (ø)
upload/views/uploads.py 99.06% <100.00%> (+<0.01%) :arrow_up:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.61%. Comparing base (f3d4bdc) to head (2e0ca33).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #699   +/-   ##
=======================================
  Coverage   91.60%   91.61%           
=======================================
  Files         631      631           
  Lines       16841    16846    +5     
=======================================
+ Hits        15428    15433    +5     
  Misses       1413     1413           
Flag Coverage Δ
unit 91.61% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.61% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
upload/views/commits.py 97.29% <100.00%> (+0.15%) :arrow_up:
upload/views/legacy.py 95.07% <ø> (ø)
upload/views/reports.py 100.00% <100.00%> (ø)
upload/views/uploads.py 99.06% <100.00%> (+<0.01%) :arrow_up:

Impacted file tree graph

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (f3d4bdc) to head (2e0ca33).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #699 +/- ## =========================================== Coverage 95.97000 95.97000 =========================================== Files 811 811 Lines 18178 18183 +5 =========================================== + Hits 17446 17451 +5 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/699/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/699/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.61% <100.00%> (+<0.01%)` | :arrow_up: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/699/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.61% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.