codecov / codecov-api

Code for the API of Codecov
Other
216 stars 30 forks source link

feat: Expose delinquent status on owner in gql #701

Closed ajay-sentry closed 2 months ago

ajay-sentry commented 2 months ago

Purpose/Motivation

Part of billing updates, https://github.com/codecov/engineering-team/issues/1814, to better show users who are currently in delinquency status, need to expose this model property in GQL to show on gazebo via query.

Also fixes a couple typos (including one on a test lol) of the word "delinquent"

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov-notifications[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (a5a5e67) to head (782f913).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16865    16869    +4     
=======================================
+ Hits        15454    15458    +4     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.63% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
billing/views.py 97.01% <ø> (ø)
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (a5a5e67) to head (782f913).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16865    16869    +4     
=======================================
+ Hits        15454    15458    +4     
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <100.00%> (+<0.01%) :arrow_up:
unit-latest-uploader 91.63% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
billing/views.py 97.01% <ø> (ø)
graphql_api/types/owner/owner.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (a5a5e67) to head (782f913).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #701 +/- ## =========================================== Coverage 95.97000 95.97000 =========================================== Files 812 812 Lines 18202 18206 +4 =========================================== + Hits 17470 17474 +4 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/701/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <100.00%> (+<0.01%)` | :arrow_up: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/701/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.