codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

Remove Rust from the Docker image #704

Closed Swatinem closed 1 month ago

Swatinem commented 1 month ago

Purpose/Motivation

If I see things correctly, codecov-ribs is the only Rust-based dependency in the dependency graph, which by now is being consumed as a prebuilt binary.

What does this PR do?

Thus there should be no need to have a Rust toolchain installed in this docker image.

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (3251d65) to head (edadd2f).

:white_check_mark: All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16868    16868           
=======================================
  Hits        15457    15457           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <ø> (ø)
unit-latest-uploader 91.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-notifications[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.63%. Comparing base (3251d65) to head (edadd2f).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         632      632           
  Lines       16868    16868           
=======================================
  Hits        15457    15457           
  Misses       1411     1411           
Flag Coverage Δ
unit 91.63% <ø> (ø)
unit-latest-uploader 91.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.97%. Comparing base (3251d65) to head (edadd2f).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #704 +/- ## =========================================== Coverage 95.97000 95.97000 =========================================== Files 812 812 Lines 18205 18205 =========================================== Hits 17473 17473 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/704/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <ø> (ø)` | | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/704/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.