Closed ajay-sentry closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
:loudspeaker: Thoughts on this report? Let us know!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.65%. Comparing base (
b3c6343
) to head (c492510
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #706 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 632 632
Lines 16917 16917
=======================================
Hits 15506 15506
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.65% <ø> (ø) |
|
unit-latest-uploader | 91.65% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
api/internal/owner/serializers.py | 99.02% <ø> (ø) |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.65%. Comparing base (
b3c6343
) to head (c492510
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #706 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 632 632
Lines 16917 16917
=======================================
Hits 15506 15506
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.65% <ø> (ø) |
|
unit-latest-uploader | 91.65% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
api/internal/owner/serializers.py | 99.02% <ø> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.98%. Comparing base (
b3c6343
) to head (c492510
).
:white_check_mark: All tests successful. No failed tests found.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose/Motivation
Part of https://github.com/codecov/engineering-team/issues/1814, originally thought we needed to update the GQL serializer, but I realized we're actually using the account-details endpoint for that component, so we should also update that serializer as well.
Long term we can swap over to the GQL serializer, but this will reduce FE code in the short term until we swap over. (And an extra network call as well)
Couple screenshots below showing null and boolean response coming back
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.