Closed ajay-sentry closed 1 month ago
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.
Completed 2244 tests with 1 failed
, 2234 passed and 9 skipped.
self = <graphql_api.tests.test_pull_comparison.TestPullComparison testMethod=test_compare_with_base_has_different_number_of_reports_on_head_and_base>
mock_has_different_number_of_head_and_base_sessions = <PropertyMock name='has_different_number_of_head_and_base_sessions' id='140673473523648'>
@patch(
"services.comparison.Comparison.has_different_number_of_head_and_base_sessions",
new_callable=PropertyMock,
)
def test_compare_with_base_has_different_number_of_reports_on_head_and_base(
self, mock_has_different_number_of_head_and_base_sessions
):
mock_has_different_number_of_head_and_base_sessions.return_value = True
query = """
compareWithBase {
... on Comparison {
hasDifferentNumberOfHeadAndBaseReports
}
}
"""
res = self._request(query)
> assert res == {
"compareWithBase": {"hasDifferentNumberOfHeadAndBaseReports": True}
}
E AssertionError: assert {'compareWithBase': None} == {'compareWith...ports': True}}
E
E Differing items:
E {'compareWithBase': None} != {'compareWithBase': {'hasDifferentNumberOfHeadAndBaseReports': True}}
E Use -v to get more diff
graphql_api/tests/test_pull_comparison.py:339: AssertionError
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.
Completed 2244 tests with 1 failed
, 2234 passed and 9 skipped.
self = <graphql_api.tests.test_pull_comparison.TestPullComparison testMethod=test_compare_with_base_has_different_number_of_reports_on_head_and_base>
mock_has_different_number_of_head_and_base_sessions = <PropertyMock name='has_different_number_of_head_and_base_sessions' id='140673473523648'>
@patch(
"services.comparison.Comparison.has_different_number_of_head_and_base_sessions",
new_callable=PropertyMock,
)
def test_compare_with_base_has_different_number_of_reports_on_head_and_base(
self, mock_has_different_number_of_head_and_base_sessions
):
mock_has_different_number_of_head_and_base_sessions.return_value = True
query = """
compareWithBase {
... on Comparison {
hasDifferentNumberOfHeadAndBaseReports
}
}
"""
res = self._request(query)
> assert res == {
"compareWithBase": {"hasDifferentNumberOfHeadAndBaseReports": True}
}
E AssertionError: assert {'compareWithBase': None} == {'compareWith...ports': True}}
E
E Differing items:
E {'compareWithBase': None} != {'compareWithBase': {'hasDifferentNumberOfHeadAndBaseReports': True}}
E Use -v to get more diff
graphql_api/tests/test_pull_comparison.py:339: AssertionError
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.
Completed 2244 tests with 1 failed
, 2234 passed and 9 skipped.
self = <graphql_api.tests.test_pull_comparison.TestPullComparison testMethod=test_compare_with_base_has_different_number_of_reports_on_head_and_base>
mock_has_different_number_of_head_and_base_sessions = <PropertyMock name='has_different_number_of_head_and_base_sessions' id='140673473523648'>
@patch(
"services.comparison.Comparison.has_different_number_of_head_and_base_sessions",
new_callable=PropertyMock,
)
def test_compare_with_base_has_different_number_of_reports_on_head_and_base(
self, mock_has_different_number_of_head_and_base_sessions
):
mock_has_different_number_of_head_and_base_sessions.return_value = True
query = """
compareWithBase {
... on Comparison {
hasDifferentNumberOfHeadAndBaseReports
}
}
"""
res = self._request(query)
> assert res == {
"compareWithBase": {"hasDifferentNumberOfHeadAndBaseReports": True}
}
E AssertionError: assert {'compareWithBase': None} == {'compareWith...ports': True}}
E
E Differing items:
E {'compareWithBase': None} != {'compareWithBase': {'hasDifferentNumberOfHeadAndBaseReports': True}}
E Use -v to get more diff
graphql_api/tests/test_pull_comparison.py:339: AssertionError
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.
Completed 2244 tests with 1 failed
, 2234 passed and 9 skipped.
self = <graphql_api.tests.test_pull_comparison.TestPullComparison testMethod=test_compare_with_base_has_different_number_of_reports_on_head_and_base>
mock_has_different_number_of_head_and_base_sessions = <PropertyMock name='has_different_number_of_head_and_base_sessions' id='140673473523648'>
@patch(
"services.comparison.Comparison.has_different_number_of_head_and_base_sessions",
new_callable=PropertyMock,
)
def test_compare_with_base_has_different_number_of_reports_on_head_and_base(
self, mock_has_different_number_of_head_and_base_sessions
):
mock_has_different_number_of_head_and_base_sessions.return_value = True
query = """
compareWithBase {
... on Comparison {
hasDifferentNumberOfHeadAndBaseReports
}
}
"""
res = self._request(query)
> assert res == {
"compareWithBase": {"hasDifferentNumberOfHeadAndBaseReports": True}
}
E AssertionError: assert {'compareWithBase': None} == {'compareWith...ports': True}}
E
E Differing items:
E {'compareWithBase': None} != {'compareWithBase': {'hasDifferentNumberOfHeadAndBaseReports': True}}
E Use -v to get more diff
graphql_api/tests/test_pull_comparison.py:339: AssertionError
Purpose/Motivation
What is the feature? Why is this being done?
Links to relevant tickets
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.