Closed michelletran-codecov closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
:loudspeaker: Thoughts on this report? Let us know!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.71%. Comparing base (
e85b89e
) to head (6d39ae7
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 91.70% 91.71%
=======================================
Files 632 632
Lines 17014 17028 +14
=======================================
+ Hits 15603 15617 +14
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.71% <100.00%> (+<0.01%) |
:arrow_up: |
unit-latest-uploader | 91.71% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...ommands/repository/interactors/fetch_repository.py | 100.00% <100.00%> (ø) |
|
core/commands/repository/repository.py | 100.00% <100.00%> (ø) |
|
graphql_api/actions/repository.py | 100.00% <100.00%> (ø) |
|
graphql_api/types/me/me.py | 100.00% <100.00%> (ø) |
|
graphql_api/types/owner/owner.py | 100.00% <100.00%> (ø) |
|
upload/views/legacy.py | 95.07% <ø> (ø) |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.71%. Comparing base (
e85b89e
) to head (6d39ae7
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 91.70% 91.71%
=======================================
Files 632 632
Lines 17014 17028 +14
=======================================
+ Hits 15603 15617 +14
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.71% <100.00%> (+<0.01%) |
:arrow_up: |
unit-latest-uploader | 91.71% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
...ommands/repository/interactors/fetch_repository.py | 100.00% <100.00%> (ø) |
|
core/commands/repository/repository.py | 100.00% <100.00%> (ø) |
|
graphql_api/actions/repository.py | 100.00% <100.00%> (ø) |
|
graphql_api/types/me/me.py | 100.00% <100.00%> (ø) |
|
graphql_api/types/owner/owner.py | 100.00% <100.00%> (ø) |
|
upload/views/legacy.py | 95.07% <ø> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.01%. Comparing base (
e85b89e
) to head (6d39ae7
).
:white_check_mark: All tests successful. No failed tests found.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose/Motivation
For organizations with
enforced
Okta configurations, we only want to show the public repos for the user. They will need to be authenticated to get access to private repos on our UI.Links to relevant tickets
ref: https://github.com/codecov/engineering-team/issues/1992
What does this PR do?
Filters out repos on the GraphQL endpoint for orgs that the user is not authenticated with for various queries that requests repository information.
Notes to Reviewer
We aren't filtering out the repos for public API endpoints. This is because these endpoints auth through token authentication are (likely, sometimes) to be used in some automated pipeline where Okta doesn't make sense.
I would like some feedback on whether there's any other API endpoints I'm missing that should have repos filtered.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.