codecov / codecov-api

Code for the API of Codecov
Other
214 stars 29 forks source link

refine admin experience #713

Closed nora-codecov closed 1 month ago

nora-codecov commented 1 month ago

Purpose/Motivation

Realized that the delete buttons weren't doing what I wanted them to do - I wanted them to delete the connection not the object. Added these customizations to prevent related objects from being deleted by accident.

Links to relevant tickets

https://github.com/codecov/engineering-team/issues/2060

Notes to Reviewer

added tests, and these changes were thoroughly tested on my local

codecov-notifications[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (e85b89e) to head (b39a1a1).

:white_check_mark: All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         632      632              
  Lines       17014    17039      +25     
==========================================
+ Hits        15603    15628      +25     
  Misses       1411     1411              
Flag Coverage Δ
unit 91.71% <100.00%> (+0.01%) :arrow_up:
unit-latest-uploader 91.71% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/admin.py 100.00% <100.00%> (ø)

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

codecov-public-qa[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.71%. Comparing base (e85b89e) to head (b39a1a1).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   91.70%   91.71%   +0.01%     
==========================================
  Files         632      632              
  Lines       17014    17039      +25     
==========================================
+ Hits        15603    15628      +25     
  Misses       1411     1411              
Flag Coverage Δ
unit 91.71% <100.00%> (+0.01%) :arrow_up:
unit-latest-uploader 91.71% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/admin.py 100.00% <100.00%> (ø)

Impacted file tree graph

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.01%. Comparing base (e85b89e) to head (b39a1a1).

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #713 +/- ## =========================================== Coverage 96.01000 96.01000 =========================================== Files 814 814 Lines 18365 18390 +25 =========================================== + Hits 17633 17658 +25 Misses 732 732 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/713/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.71% <100.00%> (+0.01%)` | :arrow_up: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/713/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `91.71% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.