Closed nora-codecov closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
:loudspeaker: Thoughts on this report? Let us know!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.71%. Comparing base (
e85b89e
) to head (b39a1a1
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 91.70% 91.71% +0.01%
==========================================
Files 632 632
Lines 17014 17039 +25
==========================================
+ Hits 15603 15628 +25
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.71% <100.00%> (+0.01%) |
:arrow_up: |
unit-latest-uploader | 91.71% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
codecov_auth/admin.py | 100.00% <100.00%> (ø) |
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.71%. Comparing base (
e85b89e
) to head (b39a1a1
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #713 +/- ##
==========================================
+ Coverage 91.70% 91.71% +0.01%
==========================================
Files 632 632
Lines 17014 17039 +25
==========================================
+ Hits 15603 15628 +25
Misses 1411 1411
Flag | Coverage Δ | |
---|---|---|
unit | 91.71% <100.00%> (+0.01%) |
:arrow_up: |
unit-latest-uploader | 91.71% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Δ | |
---|---|---|
codecov_auth/admin.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.01%. Comparing base (
e85b89e
) to head (b39a1a1
).
:white_check_mark: All tests successful. No failed tests found.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Purpose/Motivation
Realized that the delete buttons weren't doing what I wanted them to do - I wanted them to delete the connection not the object. Added these customizations to prevent related objects from being deleted by accident.
Links to relevant tickets
https://github.com/codecov/engineering-team/issues/2060
Notes to Reviewer
added tests, and these changes were thoroughly tested on my local