codecov / codecov-api

Code for the API of Codecov
Other
216 stars 30 forks source link

Remove unused logs in github webhook controller #876

Closed rohitvinnakota-codecov closed 1 week ago

rohitvinnakota-codecov commented 1 week ago

Purpose/Motivation

What is the feature? Why is this being done?

Not needed for debugging anymore. Revert https://github.com/codecov/codecov-api/pull/864

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

sentry-io[bot] commented 1 week ago

πŸ” Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

πŸ“„ File: webhook_handlers/views/github.py

Function Unhandled Issue
validate_signature UnreadablePostError: [Errno 104] Connection reset by peer /webhoo...
Event Count: 3

Did you find this useful? React with a πŸ‘ or πŸ‘Ž

codecov-notifications[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.29%. Comparing base (3c7cbc1) to head (e932891). Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #876 +/- ## ========================================== - Coverage 96.29% 96.29% -0.01% ========================================== Files 823 823 Lines 19186 19185 -1 ========================================== - Hits 18476 18475 -1 Misses 710 710 ``` | [Flag](https://app.codecov.io/gh/codecov/codecov-api/pull/876/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Ξ” | | |---|---|---| | [unit](https://app.codecov.io/gh/codecov/codecov-api/pull/876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `92.66% <ΓΈ> (-0.01%)` | :arrow_down: | | [unit-latest-uploader](https://app.codecov.io/gh/codecov/codecov-api/pull/876/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `92.66% <ΓΈ> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.