codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

Do merge sha work for Azure as it runs detached head #395

Closed thomasrockhu closed 3 years ago

thomasrockhu commented 3 years ago

Purpose

Azure Pipelines also runs in a detached head (like GitHub Actions). So this pulls the correct commit SHA

Notable Changes

This should fix an issue with users on Azure Pipelines

Tests and Risks?

Locally tested

Update the SHA hash files

Done

codecov[bot] commented 3 years ago

Codecov Report

Merging #395 (551e358) into master (11c8610) will decrease coverage by 0.13%. The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   50.34%   50.20%   -0.14%     
==========================================
  Files           5        5              
  Lines        1452     1452              
==========================================
- Hits          731      729       -2     
- Misses        721      723       +2     
Impacted Files Coverage Δ
codecov 61.26% <81.81%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11c8610...551e358. Read the comment docs.

thomasrockhu commented 3 years ago

@drazisil-codecov yeah I should, BUT I'm going to defer to another PR. I'm thinking of restructuring the entire script to be easier to test.