search

codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

Publish env checksums #425

Closed thomasrockhu closed 3 years ago

thomasrockhu commented 3 years ago

Purpose

Update the pre-commit hook to publish the env checksums also Fixes https://github.com/codecov/codecov-bash/issues/424

Notable Changes

None

Tests and Risks?

None

Update the SHA hash files

Done

adrienbernede commented 3 years ago

@drazisil-codecov @thomasrockhu This appears to break the shell script given in the documentation to check the hash. https://docs.codecov.io/docs/about-the-codecov-bash-uploader (look for "You can also verify the checksums by running").

thomasrockhu commented 3 years ago

@adrienbernede can you open a ticket in our community boards and a link to a build that is breaking for you?

adrienbernede commented 3 years ago

Done: https://community.codecov.io/t/documentation-script-snippet-to-check-hash-is-broken-since-425/2837 And the reproducer: https://github.com/adrienbernede/codecoverrordemo/runs/2471345004?check_suite_focus=true And even the fix: append the curl command with | grep codecov like here: https://github.com/mfem/github-actions/blob/82485d6bb1c64c66796804c82473b27293429505/upload-coverage/action.yml#L46