search

codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

Exit 0 on success for v2 uploading #434

Closed thomasrockhu closed 3 years ago

thomasrockhu commented 3 years ago

Purpose

The uploader does not properly handle the server-side response from the v2 uploader. This PR handles the new format Fixes https://github.com/codecov/codecov-bash/issues/415

Notable Changes

None

Tests and Risks?

None

Update the SHA hash files

N/A

codecov[bot] commented 3 years ago

Codecov Report

Merging #434 (7aadc31) into master (578ee4b) will increase coverage by 0.08%. The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   45.78%   45.87%   +0.08%     
==========================================
  Files          20       20              
  Lines        2859     2860       +1     
==========================================
+ Hits         1309     1312       +3     
+ Misses       1550     1548       -2
Flag Coverage Δ
test 39.22% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
env 0.00% <0.00%> (ø)
codecov 67.72% <50.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 578ee4b...7aadc31. Read the comment docs.

blueyed commented 3 years ago

Thanks!

btw: why does it report the (codecov) patch and project status twice here with the commit (7aadc31) above?

thomasrockhu commented 3 years ago

@blueyed one is actually a GitHub status and the other is a GitHub check. I think we hit a race condition and both were sent.