search

codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

Send Upload Token via Header #439

Closed MrJaeger closed 3 years ago

MrJaeger commented 3 years ago

Purpose

Send the upload token via header, which is more secure than as a URL param.

Tests and Risks?

I updated tests to pass, but not sure there's a good way thus token is being set as a header :(

Update the SHA hash files

Done

thomasrockhu commented 3 years ago

Should be good after you fix tests, will review again before merging in

codecov[bot] commented 3 years ago

Codecov Report

Merging #439 (2c3ae19) into master (965008c) will increase coverage by 0.03%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
+ Coverage   45.78%   45.82%   +0.03%     
==========================================
  Files          20       20              
  Lines        2859     2859              
==========================================
+ Hits         1309     1310       +1     
+ Misses       1550     1549       -1
Flag Coverage Δ
test 39.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov 67.64% <50.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 965008c...2c3ae19. Read the comment docs.