search

codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

Causes the correct server URL to be set in GitHub Actions. #441

Closed debayande closed 3 years ago

debayande commented 3 years ago

Signed-off-by: Debayan De debayande@users.noreply.github.com

Purpose

As a part of its routine for auto-detecting the underlying CI engine, the Bash uploader sets the build_url parameter to http://github.com/${GITHUB_REPOSITORY}/actions/runs/${GITHUB_RUN_ID} in L875 upon detecting GitHub Actions as the CI engine.

While this works fine for GitHub.com, it breaks uploads with HTTP 500 errors when run on GitHub Enterprise, GitHub's self-hosted sibling.

This patch, if applied, will fix the aforementioned issue (which is filed as https://github.com/codecov/codecov-bash/issues/440).

Notable Changes

No.

Tests and Risks?

This should be covered by existing tests.

Update the SHA hash files

Done.

codecov[bot] commented 3 years ago

Codecov Report

Merging #441 (a5fc10f) into master (c3ccd59) will increase coverage by 0.22%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   45.73%   45.95%   +0.22%     
==========================================
  Files          20       20              
  Lines        2858     2853       -5     
==========================================
+ Hits         1307     1311       +4     
+ Misses       1551     1542       -9
Flag Coverage Δ
test 39.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
codecov 67.96% <100.00%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3ccd59...a5fc10f. Read the comment docs.

thomasrockhu commented 3 years ago

Superceded by #457