search

codecov / codecov-bash

Global coverage report uploader for Codecov
https://codecov.io
Apache License 2.0
234 stars 155 forks source link

CI continues despite failure to release #446

Closed matthewberryman closed 3 years ago

matthewberryman commented 3 years ago

Looks like something went wrong with your releasing step, as the current published bash script doesn't match the (github) released version; an assumption that your circleci orb relies on when validating the bash script against checksums. This then breaks all my usage of codecov, which relies on the orb. More: https://github.com/codecov/codecov-circleci-orb/issues/92

Tbilgere-td commented 3 years ago

Can confirm, Checksum stopped passing for us as well on multiple environments this evening.

matthewberryman commented 3 years ago

Digging a bit deeper: This line in one of the CI scripts https://github.com/codecov/codecov-bash/blob/c3ccd596467b6c08e6fba7dba6e048dd0e341421/scripts/version.sh#L26 relies on the version being updated in the bash script (it has not been in a while, despite changes) and the CircleCI ignores the git failure. This is because the exit status of version.sh is the exit status of the git push which works despite the tagging failure. https://app.circleci.com/pipelines/github/codecov/codecov-bash/410/workflows/1579b431-5c75-467c-8044-d6bdb5e0b00a/jobs/1140

thomasrockhu commented 3 years ago

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Tbilgere-td commented 3 years ago

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Hey, just attempted a build and it appears the file at https://codecov.io/bash is still 1.0.3 and still does not pass checksum. Perhaps something to do with the 1.0.4 release not including the necessary assets?

jpeach commented 3 years ago

Hi all, I have made the change on our end and deployed 1.0.4. Please let me know if you are still experiencing the issue. It should be live within an hour.

Hey, just attempted a build and it appears the file at https://codecov.io/bash is still 1.0.3 and still does not pass checksum. Perhaps something to do with the 1.0.4 release not including the necessary assets?

Confirmed that this is still broken. 

$ curl -s -L https://codecov.io/bash | grep ^VERSION=
VERSION="1.0.3"

Since this problem is breaking CI for projects, is there a time frame for fixing it?

ouranos commented 3 years ago

Yes, still broken, had the issue this morning: https://github.com/codecov/codecov-bash/issues/449

thomasrockhu commented 3 years ago

Hi all, I made a fix in the deployment, it should be showing 1.0.4 now.

jpeach commented 3 years ago

Hi all, I made a fix in the deployment, it should be showing 1.0.4 now.

Verified that this works in our CI. Thanks @thomasrockhu :100: