search

codecov / codecov-browser-extension

A browser extension for Codecov. Works for Chrome and Firefox
Apache License 2.0
36 stars 11 forks source link

PR View Does not Show Line Coverage #26

Closed eliatcodecov closed 1 year ago

eliatcodecov commented 1 year ago

We have implemented coverage for the PR view, and you can see the totals in the PR as such:

Screenshot 2023-06-01 at 9 16 08 AM

However, there does not appear to be annotation on individual lines in the PR indicating whether or not these lines are covered, uncovered, or partial. You can see an example of this at the following PR: https://github.com/codecov/codecov-cli/pull/165/files

anukul commented 1 year ago
image

I do see it, but of course we should do a better job of highlighting errors (if any) and also have them reach the team through a Sentry integration.

Using this issue as a placeholder for this task.

eliatcodecov commented 1 year ago

I don't see it for the same PR in Dark Mode. Do you think that could be causing the issue? Screenshot 2023-06-15 at 9 05 07 AM

eliatcodecov commented 1 year ago

Upon further investigation this was an issue related to the split vs unified PR view. Line coverage works properly on the split view, does not render on unified. @anukul has pushed a fix for that with #30 that will go live as soon as the extension is approved by the Firefox and Chrome extension review process.

eliatcodecov commented 1 year ago

Confirmed working as of latest update. Closing this issue.