search

codecov / codecov-circleci-orb

MIT License
20 stars 42 forks source link

Dashes and periods in flag names don't work in the Orb #175

Open joseph-sentry opened 1 year ago

joseph-sentry commented 1 year ago

See: https://github.com/codecov/codecov-circleci-orb/pull/174

Two different errors happen for flags with . and - in the name.

For -: 

[2023-10-26T18:11:27.831Z] ['error'] There was an error running the uploader: undefined is not a function

For .: the flag name before the . just disappears

arthurio commented 11 months ago

I'm facing the same issue, I instead ~passed -F my-flag to xtra_args~ (this creates a weird blank tag, don't do that) use flag names with _ instead of periods or hyphens. The issue happens with this piece of code: eval e="\$$flag", e.g.:

flag="my-flag"
eval e="\$$flag"
echo $e
-flag