Closed nora-codecov closed 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95.95%. Comparing base (
db6ab02
) to head (10b24f7
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:white_check_mark: All tests successful. No failed tests were found.
:mega: Thoughts on this report? Let Codecov know! | Powered by Codecov
Agreed, this looks good to me. I'd like to know, however, that this change has been tested on
Went through the upload endpoints on API:
endpoints where we want to allow tokenless: I've made sure the method uses
get_token_header()
which allowsNone
for thetoken
, which will allow tokenless requests through to the api.endpoints where we don't want to allow tokenless: I've made sure they use
get_token_header_or_fail()
which does not allowNone
, so the request will be kicked out before it gets to api. This is not required for the tokenless logic to work, but is nice to have since it prevents junk requests from clogging api.update: we are going to allow tokenless uploads on all upload related endpoints, so switched them all to
get_token_header()
.get_token_header_or_fail()
is now unused, but I'm leaving it in code for if we need to switch an endpoint back to token required.https://github.com/codecov/engineering-team/issues/2300