codecov / codecov-exe

.exe report uploader for Codecov https://codecov.io

MIT License

26 stars 21 forks source link

Add new Codecov.MSBuild package providing a `Codecov`MSBuild task #135

Closed 0xced closed 3 years ago

0xced commented 3 years ago

Refactored the UploadFacade class to depend on interfaces instead of CommandLineOptions so that it's usable from the MSBuild task
Added documentation in the README about the new Codecov.MSBuild package
Updated Cake scripts to handle the new Codecov.MSBuild package

codecov[bot] commented 3 years ago

Codecov Report

Merging #135 (3f937c1) into develop (9e267ad) will increase coverage by 5.58%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #135      +/-   ##
===========================================
+ Coverage    65.15%   70.74%   +5.58%     
===========================================
  Files           39       37       -2     
  Lines         1013      916      -97     
  Branches       130      118      -12     
===========================================
- Hits           660      648      -12     
+ Misses         353      268      -85

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e267ad...3f937c1. Read the comment docs.

0xced commented 3 years ago

I just rebased and fixed the continuous integration build in 3f937c1.

0xced commented 3 years ago

I would love to see this merged. Currently I'm using the codecov dotnet tool and it's not as elegant as the proposed MSBuild task.

With the dotnet tool:

<Target Name="UploadCoverageToCodecov" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(ContinuousIntegrationBuild) == 'true'">
  <!-- For reference: the file `.config/dotnet-tools.json` was created by running `dotnet new tool-manifest && dotnet tool install Codecov.Tool` -->
  <Exec Command="dotnet tool restore" />
  <Exec Command="dotnet codecov --file &quot;@(CoverletReport, '&quot; &quot;')&quot;" />
</Target>

With the proposed MSBuild task:

<Target Name="UploadCoverageToCodecov" AfterTargets="GenerateCoverageResultAfterTest" Condition="$(ContinuousIntegrationBuild) == 'true'">
  <Codecov ReportFiles="@(CoverletReport)" />
</Target>

Also, logging is top notch with the MSBuild task.

AdmiringWorm commented 3 years ago

@0xced your changes have been merged, thanks for your contribution 👍

I have decided that this change will be included with the next version of codecov-exe, just need to find time to be able to create a new release and check out all of the pr's to update the dependencies first.

0xced commented 3 years ago

Excellent, thanks for merging! 🥳

No need to apologise for the delay, better work at a your own pace than experience open source burnout.

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.13.0 :tada:

The release is available on:

Your friendly GitReleaseManager bot :package::rocket: