atifaziz commented 3 years ago

This PR improves how arguments are specified when processes, like git, are spawned. Instead of specifying the entire command-line arguments as a single string, I have updated the code to specify arguments as a variable (params) array of strings. Terminal.Run then loads them into the new ProcessStartInfo.ArgumentList (available since .NET Core 2.1). The benefit of doing this is that the code is more portable as one doesn't have to worry about the escaping & quoting rules of each platform.

codecov[bot] commented 3 years ago

Codecov Report

Merging #152 (ffeb04e) into develop (aef48e9) will decrease coverage by 0.09%. The diff coverage is 70.00%.

@@             Coverage Diff             @@
##           develop     #152      +/-   ##
===========================================
- Coverage    65.10%   65.01%   -0.10%     
===========================================
  Files           39       39              
  Lines         1006     1009       +3     
  Branches       130      131       +1     
===========================================
+ Hits           655      656       +1     
- Misses         351      353       +2

Impacted Files	Coverage Δ
Source/Codecov/Terminal/Terminal.cs	`9.61% <25.00%> (+1.45%)`	:arrow_up:
...urce/Codecov/Services/VersionControlSystems/Git.cs	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aef48e9...ffeb04e. Read the comment docs.

AdmiringWorm commented 3 years ago

@atifaziz your changes have been merged, thanks for your contribution 👍

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.13.0 :tada:

The release is available on:

Your friendly GitReleaseManager bot :package::rocket:

codecov / codecov-exe

Use built-in args handling when launching processes #152

Codecov Report