search

codecov / codecov-exe

.exe report uploader for Codecov https://codecov.io
MIT License
25 stars 21 forks source link

Jenkins CI detection #89

Closed mikebro closed 4 years ago

mikebro commented 4 years ago

31 Adds Jenkins CI detection using the logic from codecov-bash

mikebro commented 4 years ago

Updated it.

The develop branch is behind master, confused me a little bit why I was getting failed tests all of a sudden but I was initially working off of master (IDisposable on test classes to clear environment variables isn't in develop)

AdmiringWorm commented 4 years ago

Thank you.

Hmm, seems I must have forgotten to update the develop branch after the latest hotfix release. I will take care of that when I merge in this PR.

I am about to sign off for today, but will take a look you latest commits tomorrow, and hopefully manage to get a new release with your changes.

AdmiringWorm commented 4 years ago

@mikebro Your changes have been merged and will be available in the next version of codecov-exe.

Thank you for your contribution, and sorry about the delay of getting this merged.

AdmiringWorm commented 4 years ago

hmm, looks like I won't be able to release the next version of codecov-exe yet.

There is a build error (not related to your PR) that I need to look into, unfortunately I do not have any ETA of when I would be able to do that.

mikebro commented 4 years ago

Sounds good, everything can be set manually through cli args & environment variables so it's not blocking.

AdmiringWorm commented 4 years ago

Your changes is now available in the latest version of codecov-exe.

Thank you again for your contribution.