search

codecov / codecov-exe

.exe report uploader for Codecov https://codecov.io
MIT License
25 stars 21 forks source link

Set all properties for Azure Pipelines uploads #92

Closed sharwell closed 4 years ago

sharwell commented 4 years ago

Make sure to set the build_url, project, and server_uri properties for Azure Pipelines. These properties allow the uploads to omit the codecov token.

The build and job values were also updated to match the values used by codecov-bash for Azure Pipelines.

sharwell commented 4 years ago

@AdmiringWorm are PR builds uploaded to a MyGet server where I can validate this in an actual build?

Edit: Looks like there are no PR builds at all?

sharwell commented 4 years ago

I'm currently working to validate this pull request by building it from source (via a Git submodule) in dotnet/roslyn-analyzers#3028. As soon as we can get a successful upload there, I should be able to mark this as ready for review.

AdmiringWorm commented 4 years ago

@AdmiringWorm are PR builds uploaded to a MyGet server where I can validate this in an actual build?

Edit: Looks like there are no PR builds at all?

While I would love to have appveyor set up to validate pull request on this repo, I unfortunately do not have the access to make that happen.

I have pulled in your changes to a temporary branch though, and it is running on appveyor. Once that is done, you can get the artifacts from here: https://ci.appveyor.com/project/AdmiringWorm/codecov-exe/builds/28838168/job/pw57s1s14xqq0jv0/artifacts

No myget is available though.

sharwell commented 4 years ago

I was able to complete a build using this branch. The upload proceeded without a token (good) but didn't show up properly on codecov.io (bad). I'm waiting to hear back as to the cause.

sharwell commented 4 years ago

The upload issues have now been resolved using the build from this pull request. 👍

AdmiringWorm commented 4 years ago

@sharwell your changes have been merged, thank you for your contribution 😃