codecov / codecov-exe

.exe report uploader for Codecov https://codecov.io
MIT License
25 stars 21 forks source link

Add commandline argument: -s for directory search for reports #99

Open PureKrome opened 4 years ago

PureKrome commented 4 years ago

As requested in #53 the codecov-bash script accepts a -s argument:

From the codecov-bash script:

I'm not sure how this could conflict with the existing -f argument if globbing is used in (the -f') arg. Do take note of the comment for -f in the screenshot above with respect to this:

This is non-exclusive, use -s "*.foo" to match specific paths.

so I'm not sure if this means globbing should be removed from -f ??

PureKrome commented 4 years ago

Out of interesting @AdmiringWorm - could you please confirm what the required functionality is/does for:

AdmiringWorm commented 4 years ago

@PureKrome I assume that you are talking about the functionality of them in codecov-bash. Unfortunately, I can not confirm what the functionality is there.

I can tell you what my impression of the functionality in that script though:

Now, what the -f do here in codecov-exe and what I expect the -s argument to do is somewhat diferrent

PureKrome commented 4 years ago

Thanks @AdmiringWorm !

e.g.

like that?

also, do you want -f to do globbing also?

AdmiringWorm commented 4 years ago

@PureKrome yes, exactly like that is what I envision (although, there is a need to quote the argument value to if the user would like the program instead of the shell to expand the globbing pattern).

also, do you want -f to do globbing also?

Yes, -f should still allow for globbing, both when used alone and used together with -s (although this would be in conflict with codecov-bash).