search

codecov / codecov-javascript-bundler-plugins

Set of bundler plugins that allow users to upload bundle stats to Codecov.
MIT License
4 stars 1 forks source link

build: Fix publish CI for publishing docs #108

Closed nicholas-codecov closed 3 months ago

nicholas-codecov commented 3 months ago

Description

Move CI runners to Node 20, and create a new job in the publish CI to move the TypeDoc publishing into it's own section, as well copy stuff over from the manual doc deploy to make sure ... it actually works.

Remove default rules from codecov.yml because we do the majority of our testing via integration tests which we can't collect coverage from.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.32%. Comparing base (4e1516a) to head (e688acf).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Additional details and impacted files | [Components](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/108/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [Plugin core](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/108/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.40% <ø> (ø)` | | | [Rollup plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/108/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `7.14% <ø> (ø)` | | | [Vite plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/108/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `7.14% <ø> (ø)` | | | [Webpack plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/108/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `31.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-staging[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found :relaxed:

Components Coverage Δ
Plugin core 95.40% <ø> (ø)
Rollup plugin 7.14% <ø> (ø)
Vite plugin 7.14% <ø> (ø)
Webpack plugin 31.00% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!

codecov-staging[bot] commented 3 months ago

Bundle Report

Changes will decrease total bundle size by 162.61kB :arrow_down:

Bundle name Size Change
@codecov/rollup-plugin-cjs 11.58kB 0 bytes
@codecov/bundler-plugin-core-es 5.5kB 0 bytes
@codecov/vite-plugin-es 864 bytes 10.39kB :arrow_down:
@codecov/example-rollup-app-iife 256.9kB 0 bytes
@codecov/rollup-plugin-es 11.22kB 10.42kB :arrow_up:
@codecov/example-next-app-server 325.59kB 0 bytes
@codecov/example-next-app-edge-server 306 bytes 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/webpack-plugin-es 904 bytes 0 bytes
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/example-next-app-client 894.27kB 0 bytes
@codecov/webpack-plugin-cjs 14.03kB 0 bytes
@codecov/bundler-plugin-core-cjs (removed) 151.04kB :arrow_down:
@codecov/vite-plugin-cjs (removed) 11.6kB :arrow_down:
codecov[bot] commented 3 months ago

Bundle Report

Changes will decrease total bundle size by 12.71kB :arrow_down:

Bundle name Size Change
@codecov/example-rollup-app-iife 256.9kB 0 bytes
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/vite-plugin-cjs 11.6kB 0 bytes
@codecov/vite-plugin-es 864 bytes 0 bytes
@codecov/bundler-plugin-core-cjs 151.04kB 0 bytes
@codecov/bundler-plugin-core-es 5.5kB 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/rollup-plugin-cjs 11.58kB 0 bytes
@codecov/rollup-plugin-es 794 bytes 0 bytes
@codecov/webpack-plugin-cjs 14.03kB 0 bytes
@codecov/webpack-plugin-es 904 bytes 12.71kB :arrow_down:
@codecov/example-next-app-edge-server 306 bytes 0 bytes
@codecov/example-next-app-client 894.27kB 0 bytes
@codecov/example-next-app-server 325.59kB 0 bytes
nicholas-codecov commented 3 months ago

I read back the cache documents, and I think you can put it back in. I'm sorry I didn't get a good readthrough the first time. Else, this looks fine.

😶