Closed nicholas-codecov closed 3 months ago
codecov-staging[bot]
commented
3 months ago Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.
| Components | Coverage Δ | |
|---|---|---|
| Plugin core | 95.40% <ø> (ø) |
|
| Rollup plugin | 7.14% <0.00%> (-0.11%) |
:arrow_down: |
| Vite plugin | 7.14% <0.00%> (-0.11%) |
:arrow_down: |
| Webpack plugin | 31.00% <0.00%> (-1.64%) |
:arrow_down: |
:loudspeaker: Thoughts on this report? Let us know!
codecov[bot]
commented
3 months ago Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.
Project coverage is 82.32%. Comparing base (
c6dc57c) to head (0580aef).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
codecov-staging[bot]
commented
3 months ago Changes will decrease total bundle size by 620.16kB :arrow_down:
| Bundle name | Size | Change |
|---|---|---|
| @codecov/rollup-plugin-cjs | 11.58kB | 150 bytes :arrow_up: |
| @codecov/rollup-plugin-es | 11.22kB | 10.42kB :arrow_up: |
| @codecov/webpack-plugin-es | 904 bytes | 0 bytes |
| @codecov/example-webpack-app-array-push | 71.19kB | 71.19kB :arrow_up: |
| @codecov/bundler-plugin-core-es | 5.5kB | 141.28kB :arrow_down: |
| @codecov/vite-plugin-cjs | 11.6kB | 155 bytes :arrow_up: |
| @codecov/vite-plugin-es | 11.25kB | 11.25kB :arrow_up: |
| @codecov/example-next-app-client | 894.27kB | 0 bytes |
| @codecov/bundler-plugin-core-cjs | (removed) | 151.04kB :arrow_down: |
| @codecov/example-rollup-app-iife | (removed) | 256.9kB :arrow_down: |
| @codecov/webpack-plugin-cjs | (removed) | 13.52kB :arrow_down: |
| @codecov/example-vite-app-es | (removed) | 150.59kB :arrow_down: |
codecov[bot]
commented
3 months ago Changes will increase total bundle size by 142.1kB :arrow_up:
| Bundle name | Size | Change |
|---|---|---|
| @codecov/example-rollup-app-iife | 256.9kB | 0 bytes |
| @codecov/webpack-plugin-cjs | 14.03kB | 509 bytes :arrow_up: |
| @codecov/bundler-plugin-core-es | 146.78kB | 141.28kB :arrow_up: |
| @codecov/webpack-plugin-es | 904 bytes | 0 bytes |
| @codecov/rollup-plugin-cjs | 11.58kB | 150 bytes :arrow_up: |
| @codecov/rollup-plugin-es | 794 bytes | 0 bytes |
| @codecov/example-next-app-edge-server | 306 bytes | 0 bytes |
| @codecov/example-next-app-client | 894.27kB | 0 bytes |
| @codecov/example-next-app-server | 325.59kB | 0 bytes |
| @codecov/vite-plugin-cjs | 11.6kB | 155 bytes :arrow_up: |
| @codecov/example-webpack-app-array-push | 71.19kB | 0 bytes |
| @codecov/vite-plugin-es | 864 bytes | 0 bytes |
| @codecov/bundler-plugin-core-cjs | 151.04kB | 0 bytes |
| @codecov/example-vite-app-esm | 150.59kB | 150.59kB :arrow_up: |
| @codecov/example-vite-app-es | (removed) | 150.59kB :arrow_down: |
Description
This PR modifies how the plugins handle different output formats and their aliases to create a unified output across plugins, as well as extending
estoesm.This PR also modifies how the integration tests are run, moving to a new format using a script to generate the various configs needed to test different bundler versions and output formats reducing the amount of tests that are actually needed to be written.
Closes #102
Notable Changes
esmoverescjs,esm,array-push(not sure what the better version of this might be)test-apito delete data after it's been fetched