codecov / codecov-javascript-bundler-plugins

Set of bundler plugins that allow users to upload bundle stats to Codecov.
MIT License
4 stars 1 forks source link

fix: normalizePath does not handle all base64 characters #110

Closed nicholas-codecov closed 3 months ago

nicholas-codecov commented 3 months ago

Description

This PR updates the normalizePath function, updating the regex expression to account for all base64 characters as well as - (found from testing). As these are the valid characters for the various hash functions that are used in the bundlers.

Notable Changes

codecov-staging[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Components Coverage Δ
Plugin core 95.40% <100.00%> (ø)
Rollup plugin 7.14% <ø> (ø)
Vite plugin 7.14% <ø> (ø)
Webpack plugin 31.00% <ø> (ø)

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.32%. Comparing base (bdc0533) to head (644ea15).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Additional details and impacted files | [Components](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/110/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [Plugin core](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.40% <100.00%> (ø)` | | | [Rollup plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `7.14% <ø> (ø)` | | | [Vite plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `7.14% <ø> (ø)` | | | [Webpack plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/110/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `31.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-staging[bot] commented 3 months ago

Bundle Report

Changes will increase total bundle size by 1.35MB :arrow_up:

Bundle name Size Change
@codecov/webpack-plugin-cjs 14.03kB 0 bytes
@codecov/rollup-plugin-cjs 11.58kB 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/vite-plugin-es 864 bytes 0 bytes
@codecov/rollup-plugin-es 794 bytes 10.42kB :arrow_down:
@codecov/webpack-plugin-es 904 bytes 12.71kB :arrow_down:
@codecov/bundler-plugin-core-cjs 151.24kB 151.24kB :arrow_up:
@codecov/bundler-plugin-core-es 5.5kB 0 bytes
@codecov/vite-plugin-cjs 11.6kB 0 bytes
@codecov/example-next-app-edge-server 306 bytes 306 bytes :arrow_up:
@codecov/example-next-app-server 325.59kB 325.59kB :arrow_up:
@codecov/example-next-app-client 894.27kB 894.27kB :arrow_up:
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/example-rollup-app-iife 256.9kB 0 bytes
codecov[bot] commented 3 months ago

Bundle Report

Changes will increase total bundle size by 198 bytes :arrow_up:

Bundle name Size Change
@codecov/example-rollup-app-iife 256.9kB 0 bytes
@codecov/example-next-app-server 325.59kB 0 bytes
@codecov/example-next-app-client 894.27kB 0 bytes
@codecov/vite-plugin-cjs 11.6kB 0 bytes
@codecov/example-next-app-edge-server 306 bytes 0 bytes
@codecov/webpack-plugin-cjs 14.03kB 0 bytes
@codecov/vite-plugin-es 864 bytes 0 bytes
@codecov/webpack-plugin-es 904 bytes 0 bytes
@codecov/rollup-plugin-cjs 11.58kB 0 bytes
@codecov/rollup-plugin-es 794 bytes 0 bytes
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/bundler-plugin-core-cjs 151.24kB 198 bytes :arrow_up:
@codecov/bundler-plugin-core-es 5.5kB 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes