search

codecov / codecov-javascript-bundler-plugins

Set of bundler plugins that allow users to upload bundle stats to Codecov.
MIT License
4 stars 1 forks source link

ref: Remove source maps from bundle stats #111

Closed nicholas-codecov closed 6 months ago

nicholas-codecov commented 6 months ago

Description

This PR updates the bundler plugins to exclude source maps from being added to the assets array, as they're not really a concern as they're not shipped to the end user, but they can bloat the bundle size in Gazebo and PR comment not being a true representation of size.

Closes #103

[!note] Requires #110 to be merged

Notable Changes

codecov-staging[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 2.94118% with 33 lines in your changes are missing coverage. Please review.

Files Patch % Lines
...ack-bundle-analysis/webpackBundleAnalysisPlugin.ts 4.54% 21 Missing :warning:
...llup-bundle-analysis/rollupBundleAnalysisPlugin.ts 0.00% 3 Missing and 3 partials :warning:
...c/vite-bundle-analysis/viteBundleAnalysisPlugin.ts 0.00% 3 Missing and 3 partials :warning:
Components Coverage Δ
Plugin core 95.40% <ø> (ø)
Rollup plugin 6.57% <0.00%> (-0.57%) :arrow_down:
Vite plugin 6.57% <0.00%> (-0.57%) :arrow_down:
Webpack plugin 30.47% <4.54%> (-0.53%) :arrow_down:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 2.94118% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 81.43%. Comparing base (6c02b73) to head (d2742fe).

:white_check_mark: All tests successful. No failed tests found :relaxed:

Files Patch % Lines
...ack-bundle-analysis/webpackBundleAnalysisPlugin.ts 4.54% 21 Missing :warning:
...llup-bundle-analysis/rollupBundleAnalysisPlugin.ts 0.00% 3 Missing and 3 partials :warning:
...c/vite-bundle-analysis/viteBundleAnalysisPlugin.ts 0.00% 6 Missing :warning:
Additional details and impacted files | [Components](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/111/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [Plugin core](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/111/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.40% <ø> (ø)` | | | [Rollup plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/111/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `6.57% <0.00%> (-0.57%)` | :arrow_down: | | [Vite plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/111/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `6.57% <0.00%> (-0.57%)` | :arrow_down: | | [Webpack plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/111/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `30.47% <4.54%> (-0.53%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] commented 6 months ago

Bundle Report

Changes will decrease total bundle size by 159.63kB :arrow_down:

Bundle name Size Change
@codecov/example-next-app-edge-server 306 bytes 0 bytes
@codecov/example-next-app-server 325.59kB 0 bytes
@codecov/example-next-app-client 894.27kB 0 bytes
@codecov/example-rollup-app-iife 95.45kB 161.44kB :arrow_down:
@codecov/vite-plugin-cjs 12.12kB 525 bytes :arrow_up:
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/vite-plugin-es 864 bytes 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/webpack-plugin-cjs 14.8kB 764 bytes :arrow_up:
@codecov/webpack-plugin-es 904 bytes 0 bytes
@codecov/rollup-plugin-cjs 12.1kB 519 bytes :arrow_up:
@codecov/rollup-plugin-es 794 bytes 0 bytes
@codecov/bundler-plugin-core-cjs 151.24kB 0 bytes
@codecov/bundler-plugin-core-es 5.5kB 0 bytes
codecov-staging[bot] commented 6 months ago

Bundle Report

Changes will increase total bundle size by 64.94kB :arrow_up:

Bundle name Size Change
@codecov/example-webpack-app-array-push 71.19kB 71.19kB :arrow_up:
@codecov/rollup-plugin-es 794 bytes 0 bytes
@codecov/example-next-app-server 325.59kB 0 bytes
@codecov/vite-plugin-es 864 bytes 0 bytes
@codecov/example-next-app-edge-server 306 bytes 306 bytes :arrow_up:
@codecov/example-next-app-client 894.27kB 0 bytes
@codecov/example-vite-app-esm 150.59kB 0 bytes
@codecov/example-rollup-app-iife 95.45kB 161.44kB :arrow_down:
@codecov/vite-plugin-cjs 12.12kB 12.12kB :arrow_up:
@codecov/rollup-plugin-cjs 12.1kB 519 bytes :arrow_up:
@codecov/webpack-plugin-cjs 14.8kB 764 bytes :arrow_up:
@codecov/webpack-plugin-es 904 bytes 0 bytes
@codecov/bundler-plugin-core-es 146.98kB 141.48kB :arrow_up:
@codecov/bundler-plugin-core-cjs 151.24kB 0 bytes