Closed nicholas-codecov closed 2 months ago
codecov-notifications[bot]
commented
2 months ago All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found :relaxed:
| Components | Coverage Δ | |
|---|---|---|
| Plugin core | 97.67% <ø> (ø) |
|
| Rollup plugin | 25.93% <ø> (ø) |
|
| Vite plugin | 27.09% <ø> (ø) |
|
| Webpack plugin | 40.24% <ø> (ø) |
:loudspeaker: Thoughts on this report? Let us know!
codecov[bot]
commented
2 months ago All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 82.60%. Comparing base (
eaf8836) to head (b95febb).
:white_check_mark: All tests successful. No failed tests found :relaxed:
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
codecov-staging[bot]
commented
2 months ago Changes will increase total bundle size by 1.51kB :arrow_up:
| Bundle name | Size | Change |
|---|---|---|
| @codecov/webpack-plugin-cjs | 17.32kB | 0 bytes |
| @codecov/webpack-plugin-es | 1.26kB | 0 bytes |
| @codecov/bundler-plugin-core-es | 6.03kB | 0 bytes |
| @codecov/example-rollup-app-iife | 95.45kB | 0 bytes |
| @codecov/bundler-plugin-core-cjs | 150.56kB | 0 bytes |
| @codecov/rollup-plugin-cjs | 14.58kB | 0 bytes |
| @codecov/example-webpack-app-array-push | 71.19kB | 0 bytes |
| @codecov/example-vite-app-esm | 150.59kB | 0 bytes |
| @codecov/rollup-plugin-es | 1.14kB | 12.94kB :arrow_down: |
| @codecov/vite-plugin-es | 1.08kB | 0 bytes |
| @codecov/vite-plugin-cjs | 14.46kB | 14.46kB :arrow_up: |
| @codecov/example-next-app-edge-server | 306 bytes | 0 bytes |
| @codecov/example-next-app-server | 325.59kB | 0 bytes |
| @codecov/example-next-app-client | 894.27kB | 0 bytes |
codecov[bot]
commented
2 months ago Changes will increase total bundle size by 150.75kB :arrow_up:
| Bundle name | Size | Change |
|---|---|---|
| @codecov/example-next-app-edge-server | 306 bytes | 0 bytes |
| @codecov/webpack-plugin-cjs | 17.32kB | 0 bytes |
| @codecov/bundler-plugin-core-es | 146.32kB | 140.3kB :arrow_up: |
| @codecov/webpack-plugin-es | 1.26kB | 15.38kB :arrow_down: |
| @codecov/rollup-plugin-es | 14.08kB | 12.94kB :arrow_up: |
| @codecov/example-webpack-app-array-push | 71.19kB | 0 bytes |
| @codecov/example-rollup-app-iife | 95.45kB | 0 bytes |
| @codecov/vite-plugin-es | 13.96kB | 12.89kB :arrow_up: |
| @codecov/example-next-app-client | 894.27kB | 0 bytes |
| @codecov/example-vite-app-esm | 150.59kB | 0 bytes |
| @codecov/bundler-plugin-core-cjs | 150.56kB | 0 bytes |
| @codecov/rollup-plugin-cjs | 14.58kB | 0 bytes |
| @codecov/vite-plugin-cjs | 14.46kB | 0 bytes |
| @codecov/example-next-app-server | 325.59kB | 0 bytes |
Description
Ran into some issues with handling duplicate bundle names, so this PR fixes that by creating primary keys off of the
idandbundle_namecolumns, and also requiring the ID when grabbing details by bundle name. (basically all server builds for nuxt were esm soooo that didn't work just using the bundle name)