search

codecov / codecov-javascript-bundler-plugins

Set of bundler plugins that allow users to upload bundle stats to Codecov.
MIT License
4 stars 1 forks source link

feat: Hard fail on invalid bundle names #136

Closed nicholas-codecov closed 1 month ago

nicholas-codecov commented 1 month ago

Description

This PR updates the plugins to hard fail when a user passes an invalid bundle name, exiting the process. This is a small change, but should really help people when setting up the bundler plugins if they're not getting any data in Codecov but still seeing checkmarks across their CI.

Closes #124

Notable Changes

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 48.61111% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 77.75%. Comparing base (91e933f) to head (abbbcdd).

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
packages/bundler-plugin-core/src/index.ts 0.00% 11 Missing :warning:
packages/vite-plugin/src/index.ts 0.00% 6 Missing :warning:
packages/nuxt-plugin/src/index.ts 0.00% 5 Missing :warning:
packages/rollup-plugin/src/index.ts 0.00% 5 Missing :warning:
packages/sveltekit-plugin/src/index.ts 0.00% 5 Missing :warning:
packages/webpack-plugin/src/index.ts 0.00% 5 Missing :warning:
Additional details and impacted files | [Components](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/136/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [Plugin core](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/136/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.68% <76.08%> (-0.19%)` | :arrow_down: | | [Rollup plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/136/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `10.37% <0.00%> (-0.08%)` | :arrow_down: | | [Vite plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/136/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `10.52% <0.00%> (-0.08%)` | :arrow_down: | | [Webpack plugin](https://app.codecov.io/gh/codecov/codecov-javascript-bundler-plugins/pull/136/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `26.04% <0.00%> (-0.16%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] commented 1 month ago

Bundle Report

Changes will increase total bundle size by 1.04kB :arrow_up:

Bundle name Size Change
@codecov/sveltekit-plugin-cjs 1.32kB 25 bytes :arrow_up:
@codecov/nuxt-plugin-cjs 1.4kB 25 bytes :arrow_up:
@codecov/sveltekit-plugin-esm 909 bytes 0 bytes
@codecov/nuxt-plugin-esm 855 bytes 0 bytes
@codecov/vite-plugin-cjs 2.96kB 34 bytes :arrow_up:
@codecov/example-rollup-app-iife 95.45kB 0 bytes
@codecov/vite-plugin-esm 1.26kB 0 bytes
@codecov/bundler-plugin-core-cjs 42.09kB 146 bytes :arrow_up:
@codecov/example-next-app-server-cjs 342.32kB 0 bytes
@codecov/bundler-plugin-core-esm 7.32kB 760 bytes :arrow_up:
@codecov/example-next-app-edge-server-array-push 354 bytes 0 bytes
@codecov/rollup-plugin-cjs 2.96kB 25 bytes :arrow_up:
@codecov/webpack-plugin-cjs 3.59kB 25 bytes :arrow_up:
@codecov/rollup-plugin-esm 1.32kB 0 bytes
@codecov/webpack-plugin-esm 1.44kB 0 bytes
@codecov/example-next-app-client-array-push 907.85kB 0 bytes
@codecov/example-webpack-app-array-push 71.19kB 0 bytes
@codecov/example-vite-app-esm 150.61kB 0 bytes