codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
72 stars 82 forks source link

Relax Ruby version constraint #122

Closed n-rodriguez closed 3 years ago

n-rodriguez commented 3 years ago

Fix https://github.com/codecov/codecov-ruby/issues/121

codecov[bot] commented 3 years ago

Codecov Report

Merging #122 (2b34672) into master (04bcb6f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files           1        1           
  Lines         359      359           
=======================================
  Hits          325      325           
  Misses         34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04bcb6f...2b34672. Read the comment docs.

n-rodriguez commented 3 years ago

So Rails is wrong too? https://github.com/rails/rails/blob/master/activerecord/activerecord.gemspec#L12

AlexWayfer commented 3 years ago

So Rails is wrong too? https://github.com/rails/rails/blob/master/activerecord/activerecord.gemspec#L12

I think, yes. Do you assume it can't be? Ha-ha. Rails has many errors (see issues), some of them potential (not noticed or not important for now). It's OK, but we can do it better. Rails is not a standard for Ruby (especially out of web).

If you can argue with something except "some gem has this too", but with something truly about Ruby and the subject — please, do.

n-rodriguez commented 3 years ago

See the 2019 ruby conf and matz presentation about backward compatibilty. It should br sufficient.

AlexWayfer commented 3 years ago

See the 2019 ruby conf and matz presentation about backward compatibilty. It should br sufficient.

OK, I've checked it. I saw this: https://youtu.be/2g9R7PUCEXo?t=1004

Ruby 3.0 (?)

So, there were plans for Ruby 2.7 but unknown changes for Ruby 3.0. Because it's unknown feature, and even some changes become reverted before releases.