codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
72 stars 82 forks source link

Improve gemspec more #123

Closed AlexWayfer closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #123 (cadeba9) into master (e0aa49e) will decrease coverage by 2.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   91.91%   89.41%   -2.50%     
==========================================
  Files           3        3              
  Lines         371      378       +7     
==========================================
- Hits          341      338       -3     
- Misses         30       40      +10     
Impacted Files Coverage Δ
lib/codecov/formatter.rb 90.00% <0.00%> (-4.00%) :arrow_down:
lib/codecov/uploader.rb 88.95% <0.00%> (-2.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0aa49e...cadeba9. Read the comment docs.

n-rodriguez commented 3 years ago

Btw the next ruby release will be the 3.1, not 4. So '>= 2.4, < 4' is totally useless and could stand here for 10 years (the time to release ruby 4) without protecting you from any incompatibilities. My 2 cents.

AlexWayfer commented 3 years ago

Btw the next ruby release will be the 3.1, not 4. So '>= 2.4, < 4' is totally useless and could stand here for 10 years (the time to release ruby 4) without protecting you from any incompatibilities. My 2 cents.

  1. It's not related to this PR, I don't change any versions.
  2. 3.1 is less than 4 (3.1 < 4), and it's backward compatible with 3.x. It's Semver.
  3. It's OK to not change version (at least upper one) for ten years.
AlexWayfer commented 3 years ago

As always, thanks so much @AlexWayfer for your contributions

Thank you for your service! ❤️ I'm glad to help you with Ruby as mush as I can.