search

codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
73 stars 82 forks source link

open simplecov requirement to 0.21.x #125

Closed klausbadelt closed 3 years ago

klausbadelt commented 3 years ago

This PR allows the latest version of simplecov. 0.21.x was explicitly excluded, but I see no issues and tests pass. Please let me know if I'm missing anything.

codecov[bot] commented 3 years ago

Codecov Report

Merging #125 (f360765) into master (04bcb6f) will increase coverage by 1.23%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
+ Coverage   90.52%   91.76%   +1.23%     
==========================================
  Files           1        1              
  Lines         359      340      -19     
==========================================
- Hits          325      312      -13     
+ Misses         34       28       -6
Impacted Files Coverage Δ
lib/codecov.rb 91.76% <0.00%> (+1.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04bcb6f...f360765. Read the comment docs.

klausbadelt commented 3 years ago

I missed the discussion in #116. Still, tests don't fail with simplecov 0.21.2. If your parser would fail now, I suggest we need tests here to reflect the requirement.

jerrode commented 3 years ago

Thanks @klausbadelt! Excited to have you using Codecov.