search

codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
72 stars 82 forks source link

Add support for AWS CodeBuild as CI provider #56

Closed rasarora closed 3 years ago

rasarora commented 4 years ago

Add support for AWS CodeBuild as CI provider

codecov[bot] commented 3 years ago

Codecov Report

Merging #56 into master will increase coverage by 0.20%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   91.93%   92.13%   +0.20%     
==========================================
  Files           1        1              
  Lines         347      356       +9     
==========================================
+ Hits          319      328       +9     
  Misses         28       28
Impacted Files Coverage Δ
lib/codecov.rb 92.13% <100.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9035124...92e82b2. Read the comment docs.

thomasrockhu commented 3 years ago

@rasarora thanks for this!

klausbadelt commented 3 years ago

@thomasrockhu excited to see official CodeBuild support.

CODEBUILD_ID is nowhere mentioned in the CodeBuild docs though - you guys sure that's set by AWS? (I used CODEBUILD_BUILD_ID to identify CodeBuild in my previous PR).

Sorry for the late question!

thomasrockhu commented 3 years ago

@klausbadelt, a little confused here, I think the PR is using CODEBUILD_BUILD_ID