search

codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
72 stars 82 forks source link

Rubocop #59

Closed thomasrockhu closed 4 years ago

thomasrockhu commented 4 years ago

Run rubocop to get some styling

codecov[bot] commented 4 years ago

Codecov Report

Merging #59 into master will decrease coverage by 2.74%. The diff coverage is 89.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
- Coverage   93.65%   90.90%   -2.75%     
==========================================
  Files           1        1              
  Lines         205      209       +4     
==========================================
- Hits          192      190       -2     
- Misses         13       19       +6
Impacted Files Coverage Δ
lib/codecov.rb 90.90% <89.92%> (-2.75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ab3ae2...e9e5096. Read the comment docs.

thomasrockhu commented 4 years ago

@drazisil I'm going to ignore the coverage decrease, because the new lines are not.... easily testable. How am I going to fake an error doing a real API call?

drazisil commented 4 years ago

Why do a real api call? Can't you mock?

thomasrockhu commented 4 years ago

@drazisil we can, but I'd like to push it out of scope of this PR