search

codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
72 stars 82 forks source link

Enable branch coverage #73

Open klyonrad opened 3 years ago

klyonrad commented 3 years ago

The simplecov gem added support for displaying branch coverage for a while now. It would be nice if codecov would do that too.

thomasrockhu commented 3 years ago

Thanks here @klyonrad, we are looking to support Simplecov 0.18+ and will add its branch coverage to the product map.

thomasrockhu commented 3 years ago

@klyonrad, do you have a build with branch coverage? Now that 0.18+ is supported, we'd love to move forward here.

klyonrad commented 3 years ago

Sorry, @thomasrockhu I don't quite understand the question or what you require. I used branch coverage a couple of times in my projects and it worked. Enabling it should require minimal configuration

thomasrockhu commented 3 years ago

@klyonrad, sorry for not explaining myself more. Do you have a public repository that is currently collecting branch coverage?

klyonrad commented 3 years ago

@thomasrockhu Here would be an exmaple: https://github.com/klyonrad/lazybar/blob/master/spec/spec_helper.rb#L5

marcotc commented 3 years ago

👋 @thomasrockhu, our team was also trying to report branch coverage results and noticed that they don't get picked up by the codecov gem. We submit our results by configuring the SimpleCov::Formatter::Codecov: https://github.com/DataDog/dd-trace-rb/blob/7e6fdb0a8c948a9e36f6f618350566e74c2d92b1/Rakefile#L958-L967

Like @thomasrockhu said, adding SimpleCov.enable_coverage :branch to any project that is currently exporting to Codecov will allow you to see that "branches": [...] data is present in the .resultset.json SimpleCov result, but not present in the payload sent by codecov.

thomasrockhu commented 3 years ago

Hi @marcotc! We are working on parsing the branch coverage information this month. After that's in place, I'll be making the change to the uploader to send that information to Codecov using this gem. I'll ping back here with updates, but we are really looking forward to getting this feature rolled out.