search

codecov / codecov-ruby

Ruby uploader for Codecov
https://codecov.io
MIT License
73 stars 82 forks source link

Fix jruby-9.1.x compatibility #79

Closed mainameiz closed 4 years ago

mainameiz commented 4 years ago

While making a PR into aasm. I found that new version of codecov does not work in jruby 9.1.x (9.1.12.0 actually). You can find failed build on travis-ci.org in the first commit in this PR.

Reason is that GzipWriter#close does not return instance of underlying IO-like object.

It was broken in 0.1.20 release here.

Changes:

First commit in this PR adds jruby 9.1.12.0 into .travis.yml to show that it fails before changes and passes after fixing.

codecov[bot] commented 4 years ago

Codecov Report

Merging #79 into master will increase coverage by 1.59%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   88.65%   90.24%   +1.59%     
==========================================
  Files           1        1              
  Lines         326      328       +2     
==========================================
+ Hits          289      296       +7     
+ Misses         37       32       -5
Impacted Files Coverage Δ
lib/codecov.rb 90.24% <100.00%> (+1.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 627ce66...53b8751. Read the comment docs.