search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Missing lines table not showing #1129

Closed codecovdesign closed 2 months ago

codecovdesign commented 8 months ago

Describe the bug In this example: https://github.com/getsentry/sentry/pull/64245/

User notices the missing lines, but the the intended table that has the files with missing lines is not appearing.

Could be related to configuration adjustments in yaml missing header:

Related behavior: https://github.com/codecov/engineering-team/issues/1041

Expected behavior that the table shows that outlines files related to the missing lines

pr_comment_missing_lines

eliatcodecov commented 8 months ago

The action here is that the table should be part of the header so that it's displayed alongside the header. Assigning to @codecovdesign

Likely more investigation to do here to determine if this is actually a bug or we just need to change the current settings and layout behavior.

joseph-sentry commented 8 months ago

Do we want to get rid of the old behaviour completely or leave it configurable?

codecovdesign commented 5 months ago

@joseph-sentry sorry, looks like I missed this, going to send you a quick sync to debug/discuss this one!

codecovdesign commented 5 months ago

review with @joseph-sentry, here is the config file that doesn't show the missing files

comment:
  # This is the addition of carry forward builds and fresh builds, thus, it's the addition
  # of the FE and BE builds
  after_n_builds: 22
  layout: 'diff, files'
  # Update, if comment exists. Otherwise post new.
  behavior: default
  # Comments will only post when coverage changes. Furthermore, if a comment
  # already exists, and a newer commit results in no coverage change for the
  # entire pull, the comment will be deleted.
  require_changes: true
  require_base: true # must have a base report to post
  require_head: true # must have a head report to post

the issue is the input of files doesn't include the newfiles (source) in this file we selected section names (https://github.com/codecov/worker/blob/50cd0a4f74d83bef0aadcd4255e1953cedab0682/services/notification/notifiers/mixins/message/__init__.py)

goal: we want the newfile table to show by default. update to show the missing files by default

codecovdesign commented 2 months ago

@thomasrockhu-codecov doing some houskeeping on issues and notice this one wasn't assigned - looks like it's ready to resolve. @joseph-sentry lmk if something is missing

thomasrockhu-codecov commented 2 months ago

@codecovdesign, just to clarify this a little bit. Do you want

  1. if files is in the configuration, to display the newfiles section as well?
  2. show the newfiles section by default for all configurations

If 2, how would a user turn it off if they don't want it?