codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

When components / flags selected --> maintain consistency in coverage data across `repo overview` #1269

Open jerrodcodecov opened 8 months ago

jerrodcodecov commented 8 months ago

What product do you want to improve? Repo overview page

Is your feature request related to a problem? Please describe. Right now, when you select certain set of components or flags on a given branch, it's actually not obviously in the file tree what the overall coverage is for the selected set of components or flags

image

Describe the solution you'd like I think it would make sense to include a "total" or "sub-total" in the file tree view

Describe alternatives you've considered Alternatively, we could also have the sunburst, coverage over time and repo coverage numbers update dynamically as components are selected.

If we don't take this approach, we should additionally clarify that the "selected components / flags" are only applicable to the file tree, and not metrics "above the line"

image

Additional context Brought up by an enterprise customer

### Tasks
- [ ] https://github.com/codecov/engineering-team/issues/1453
- [ ] https://github.com/codecov/engineering-team/issues/1442
- [ ] https://github.com/codecov/engineering-team/issues/1455
jerrodcodecov commented 7 months ago

@codecovdesign seeking an update on ingestion on this matter, thanks!

codecovdesign commented 7 months ago

@jerrodcodecov thanks ping, marking in-discovery, adding to design sprint (upcoming) and will finalize/prep to dev ready

codecovdesign commented 7 months ago

@katia-sentry here's demo/prototype based on the description suggestion. The design can be broken down in different ways and depending on the constraints the page could work together or separately; here are areas it'd be great to look at:

https://github.com/codecov/engineering-team/assets/87861036/a50e49a8-7603-41f3-98e5-5d2af07535e0

Could we schedule a design/eng discovery around this one?

katia-sentry commented 7 months ago

@codecovdesign yes we can schedule a sync for this with @RulaKhaled and @rohitvinnakota-codecov

codecovdesign commented 7 months ago

review with @rohitvinnakota-codecov @RulaKhaled 3/20

codecovdesign commented 7 months ago

review 2 with @rohitvinnakota-codecov and @RulaKhaled

Next steps are to resolve the bug findings, then revisit the updates to filtering / sunburst etc

vlad-ko commented 4 months ago

Do we have any update that I could share with the customers?

codecovdesign commented 4 months ago

@vlad-ko it looks like the initial blockers have been addressed; tentatively moving https://github.com/codecov/engineering-team/issues/1453 to dev ready cc @katia-sentry

katia-sentry commented 4 months ago

Thanks @vlad-ko @codecovdesign. I've added https://github.com/codecov/engineering-team/issues/1453 to next sprint