RulaKhaled
commented
3 months ago @codecovdesign My plan to tackle this ticket is:
- Set the branch as a URL parameter instead of a search parameter. We've been interchangeably switching between these two, and it's time to have a clear approach for handling URLs. We will also be mocking GitHub's approach, which is a win. This will be handled in another ticket.
- Handle branch mismatches. For this, I think we need to discuss unifying the navigation header between these tabs. Is this something you would like to see, @codecovdesign? We can also sync on this if I'm not clear enough!
katia-sentry
The display of a selected branch on the breadcrumb is misleading because it only applies to the current page, not to other pages (like Coverage, bundles, flags...)
When we switch tabs the selected branch didn't response/update to the correct branch.
https://github.com/codecov/engineering-team/assets/152432831/e2e5109f-1b24-4402-8b87-f4ec7d1841f3