search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 0 forks source link

PR report hit/misses number incorrect and/or unknown source #1632

Open codecovdesign opened 3 weeks ago

codecovdesign commented 3 weeks ago

Describe the bug In this example: https://github.com/maplibre/maplibre-gl-js/pull/4014#issuecomment-2063476003, the hits/misses totals are incorrect / unknown-source.

Screenshot 2024-04-18 at 9 38 51 AM
HarelM commented 3 weeks ago

Although I wrote it in the mail, here's some info that might help: The run uploads 7 coverage files. The first one that usually gets uploaded is unit test coverage which is around 70%. So if I need to guess, only after the first file the comment was updated and not after evey file upload. This is a guess.

Another thing to note is the there's a -0.15% coverage degradation (in codecov.io) but the main branch and this one have the same code - i.e. there were no test or code changes, just added the tests upload to the CI basically.

The indirect changes also are weird, but it's probably a side effect of the above issue.

I'm here if anything needs classification in terms of what's running, when, how etc...

eliatcodecov commented 1 week ago

@michelletran-codecov to investigate. @vlad-ko has more context if needed.