codecov / engineering-team

This is a general repo to use with GH Projects
2 stars 1 forks source link

Move adjust_base behavior sooner in the pipeline before notify #1703

Open drazisil-codecov opened 3 weeks ago

drazisil-codecov commented 3 weeks ago

Move adjust_base behavior sooner in the pipeline before notify

We currently xan run of for every flag, which seems inefficient.

That's a good feature request. The reason it's done like it is done now is probably because the comparison filter is applied first, and the notification for each flag receives the filtered comparison, not the original one (https://github.com/codecov/worker/blob/9a02734fe15641e5095d4376a096ff2da8a0631d/services/notification/notifiers/mixins/status.py#L275) But if we move the removed code behavior functions to the comparison instead of the status patch we should be able to do what you want, I guess? A good optimization I believe