codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

[OKTA] Add user login check to account -> account settings for OKTA #1745

Closed trent-codecov closed 1 month ago

trent-codecov commented 3 months ago

On user login follow the flow outlined below:

flowchart LR
    A[User Login Request]
    A --> B{Check for Account Settings}
    B -->|No settings| C[Normal Login Flow]
    B -->|Settings present without authentication modifications| C
    B -->|Settings present with authentication modifications| D[Modified Login Flow]

Modified login flow will be the OKTA login flow we already have created. Design this so that we can use other flows e.g. Sentry or any other 3rd party auth provider we add.

michelletran-codecov commented 2 months ago

Ah, this ticket might not make sense anymore. The currently workflow will assume that a user is already signed into GitHub, and Okta is another layer of authentication on top of the user's login authentication. I don't think the workflow for signing in the user straight from Okta will be in scope for now.

In a diagram:

flowchart LR
    A[User Login to Code Provider]
    A --> B{Attempts to view Org<br/> that requires extra Okta<br/> configurations}
    B -->|No settings| C[Show Organization's private repos]
    B -->|Settings present and<br/> already logged into<br/> Okta for that Account| C
    B -->|Settings present and<br/> not already logged into<br/> Okta for that Account| D[Show Okta Login Flow<br/> for that Account]