codecov / engineering-team

This is a general repo to use with GH Projects
2 stars 1 forks source link

Add an annotation to explain the visual cue for indicating the number of reports targeting the line #1874

Closed Adal3n3 closed 3 days ago

Adal3n3 commented 1 month ago

Problem to solve

Customers do not understand what this number means, and it creates confusion. As you can read the slack thread conversation. Screenshot 2024-06-06 at 3 41 34 PM

Slack thread: https://sentry.slack.com/archives/C04DL8SRBUZ/p1717657302671339

Screenshot 2024-06-06 at 4 22 14 PM

Solution

We should add an annotation to explain what the number means. Credit to @vlad-ko's for the good suggestion: "No. reports with line" Screenshot 2024-06-06 at 4 20 19 PM

Action Checklist for Issue Creation

Additional Information

### Related issues
- [ ] https://github.com/codecov/engineering-team/issues/1878
- [ ] https://github.com/codecov/engineering-team/issues/1880
Adal3n3 commented 1 month ago

@katia-sentry @nicholas-codecov We would like to add this annotation in the UI, do you need a figma file or this screenshot will do the job? Screenshot 2024-06-06 at 4 20 19 PM

nicholas-codecov commented 1 month ago

So couple things:

Adal3n3 commented 1 month ago

Improve the label and color to make the design stand up a little bit more

Screenshot 2024-06-06 at 8 51 18 PM

Adal3n3 commented 1 month ago

Making a note here @aj-codecov confirming with you to make sure the pull page should not have the uploads count (cc @nicholas-codecov) If this is true - please move this issue forward https://github.com/codecov/engineering-team/issues/1878

nicholas-codecov commented 1 month ago

poke @aj-codecov 👀

nicholas-codecov commented 1 month ago

@Adal3n3 can you link the figma designs please

Adal3n3 commented 1 month ago

@nicholas-codecov Sorry about missing the link. Here's the figma link

nicholas-codecov commented 1 month ago

Thanks @Adal3n3!

nicholas-codecov commented 5 days ago

poke @aj-codecov