search

codecov / engineering-team

This is a general repo to use with GH Projects
2 stars 1 forks source link

Update YAML configuration #2004

Open giovanni-guidini opened 2 weeks ago

giovanni-guidini commented 2 weeks ago

For the MVP the gating item is "entire bundle".

Example configuration

bundle_analysis:
  status: True / False / "informational" # default is "informational"
  bundle_change_threshold: "10 mb" / "10%" / 100 # default is 10%

# This part already exists
comment:
  require_bundle_changes: True
  bundle_change_threshold: "10 mb" / "10%" / 100 # coercion needs to accept percentage
This is not part of the MVP Ability to emit checks based on the different bundle groupings available REPORT_SIZE (summary of all other cathegories) JAVASCRIPT_SIZE STYLESHEET_SIZE FONT_SIZE IMAGE_SIZE ASSET_SIZE (all assets not classified in another cathegory)
giovanni-guidini commented 1 week ago

We currently have "bite_size" and "percentage_to_number" coercions. Part of this task will be creating a "bundle_change_treshhold" coersion that can handle both.

The catch will then be that a float is a percentage and an integer is an absolute size in bytes